Add @openai/apps-sdk-ui packages to optimizeDeps#11
Merged
Conversation
Revert "Add @openai/apps-sdk-ui packages to optimizeDeps" This reverts commit 74203ad. Add @openai/apps-sdk-ui packages to optimizeDeps
74203ad to
72f74b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the plugin only conditionally included the Gadget package in Vite's
optimizeDeps.includeconfiguration, which meant that projects using the@openai/apps-sdk-uipackage would fail to load on the first page visit during development, requiring users to manually refresh the page before the widgets would work.This PR adds an
optimizeDeps.entriesconfiguration that tells Vite to scan all widget files (${widgetsDir}/**/*.{jsx,tsx}) as entry points for dependency optimisation. This ensures that any dependencies imported by widget components—including UI libraries like the Gadget package or OpenAI Apps SDK UI components—are automatically discovered and pre-bundled by Vite, allowing widgets to load correctly on the first visit without requiring a page refresh.