Use Encoder scratch space instead of allocating scratch space per-call#13
Open
palmerlao wants to merge 1 commit intogagliardetto:masterfrom
Open
Use Encoder scratch space instead of allocating scratch space per-call#13palmerlao wants to merge 1 commit intogagliardetto:masterfrom
palmerlao wants to merge 1 commit intogagliardetto:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also changes the TypeSizes to constants so that I can use
TypeSizeUint128to have the fixed-size array field inEncoder. Removing these allocations seems to halve the time my workload spends encoding data. The flame graph below shows the before (left) and after (right).