Skip to content

fix flaky test#363

Merged
gaissmai merged 2 commits intomainfrom
devel
Feb 3, 2026
Merged

fix flaky test#363
gaissmai merged 2 commits intomainfrom
devel

Conversation

@gaissmai
Copy link
Owner

@gaissmai gaissmai commented Feb 3, 2026

Summary by CodeRabbit

  • Documentation

    • Updated CONTRIBUTING.md to clarify documentation update guidelines.
  • Tests

    • Added architecture compatibility checks to test suite for 64-bit platforms (amd64, arm64).
  • Chores

    • Updated copyright year to 2026.
    • Removed internal documentation references from codebase.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

Documentation comments referencing ART implementation details and paper references are removed across multiple internal node files. The test file is updated with a 2026 copyright year, runtime import, and an architecture guard limiting test execution to 64-bit architectures. A minor wording change in contributing guidelines is also made.

Changes

Cohort / File(s) Summary
Documentation Comment Removals
internal/art/base_index.go, internal/nodes/bartmethodsgenerated.go, internal/nodes/commonmethods_tmpl.go, internal/nodes/fast.go, internal/nodes/fastmethodsgenerated.go, internal/nodes/litemethodsgenerated.go
Removed references to artlookup.pdf and related documentation comments from various internal node implementations.
Contributing Guide Update
CONTRIBUTING.md
Minor wording change: "Update docs/README when behavior or APIs change." updated to "Update README when behavior or APIs change."
Test Maintenance
zz-inliner_test.go
Updated copyright year to 2026, added runtime import, and added architecture guard to TestInlineBitSet256Functions to restrict execution to amd64 or arm64 architectures.

Possibly Related PRs

  • nit with modernize #350 — Updates comment text in the same generated/internal node files (internal/nodes/\*methodsgenerated.go), suggesting coordinated documentation cleanup.
  • tweak tests and benchmarks #346 — Introduces TestInlineBitSet256Functions; this PR adds the architecture guard implementation for that test.

Poem

🐰 Comments take flight, like leaves in the breeze,
PDF references fade with architectural ease,
Tests now know their place—sixty-four bits or bust,
A cleaner codebase, in which we trust! ✨


🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix flaky test' accurately describes the main change in the pull request, which adds an architecture guard to skip TestInlineBitSet256Functions on non-64-bit architectures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devel

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21645254745

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.244%

Totals Coverage Status
Change from base Build 19715771528: 0.01%
Covered Lines: 6888
Relevant Lines: 7549

💛 - Coveralls

@gaissmai gaissmai merged commit a741d1d into main Feb 3, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants