Skip to content

fix broken benchmark#364

Merged
gaissmai merged 1 commit intomainfrom
devel
Feb 6, 2026
Merged

fix broken benchmark#364
gaissmai merged 1 commit intomainfrom
devel

Conversation

@gaissmai
Copy link
Owner

@gaissmai gaissmai commented Feb 6, 2026

Summary by CodeRabbit

  • Tests
    • Updated benchmark test configurations to improve measurement consistency.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Walkthrough

Benchmark tests in zz-bench_test.go have been updated to instantiate generic types with bool instead of struct{}. All corresponding Insert() calls and type declarations (Fast[bool], Table[bool]) have been consistently updated. Control flow remains unchanged.

Changes

Cohort / File(s) Summary
Benchmark Type Parameter Updates
zz-bench_test.go
Updated generic type parameter from struct{} to bool across all benchmarks. Insert method calls changed from struct{}{} to true, and type instantiations from Fast[struct{}] / Table[struct{}] to Fast[bool] / Table[bool].

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Poem

🐰 From struct\{\} to bool, so neat,
Benchmarks hop with payloads sweet,
True and false now lead the race,
Performance tested at brisk pace! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix broken benchmark' directly describes the main change—updating benchmarks that were broken due to type parameter changes from struct{} to bool.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch devel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21763134955

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.244%

Totals Coverage Status
Change from base Build 21645714854: 0.01%
Covered Lines: 6888
Relevant Lines: 7549

💛 - Coveralls

@gaissmai gaissmai merged commit 62ee64b into main Feb 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants