Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make fields configurable for determining whether or not to fetch edges #614

Conversation

mikeroelens
Copy link
Contributor

Right now rows are fetched based on whether or not edges or pageInfo fields are requested. In some APIs there may be alternative naming for fields, e.g. data instead of edges. By introducing resolverFieldsThatRequireFetchingEdges?: string[] as a configuration variable it allows users to specify what fields if requested should trigger fetching rows.

Default values are still edges and pageInfo

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: 4207ad4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@slonik/dataloaders Minor
@slonik/types Minor
@slonik/utilities Minor
@slonik/errors Minor
@slonik/sql-tag Minor
@slonik/driver Minor
@slonik/pg-driver Minor
@slonik/benchmark Minor
slonik Minor
slonik-interceptor-field-name-transformation Minor
slonik-interceptor-query-cache Minor
slonik-interceptor-query-logging Minor
slonik-sql-tag-raw Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikeroelens mikeroelens changed the title feat: make fields configurable for determining whether or not to fetch edges configurable feat: make fields configurable for determining whether or not to fetch edges May 29, 2024
@gajus gajus merged commit ce9b19c into gajus:main May 29, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants