fix: resolve issue with dependency generation#54
Open
jtabibito wants to merge 22 commits into
Open
Conversation
Merge from galacean/platform-adapter:main
Resolve conflicts
feat: drop unused scripts
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a brace placement issue that was causing incorrect scope for dependency generation logic. The key change moves the initialization of buildSettings.dependencies = [] to occur after WASM module processing is complete, ensuring proper execution order.
Key Changes
- Removed premature initialization of
buildSettings.dependenciesarray - Added proper initialization of dependencies array after WASM processing
- Fixed brace placement issue that was causing incorrect code block nesting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.