refactor: consolidate common/table into @repo/shared/components/table (#1516)#1517
Open
frano-m wants to merge 1 commit into
Open
refactor: consolidate common/table into @repo/shared/components/table (#1516)#1517frano-m wants to merge 1 commit into
frano-m wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates the previously app-local common/Table implementation into the shared package @repo/shared/components/Table, aligning the shared Table component structure with the consolidated reference and updating application consumers to import from the shared location.
Changes:
- Moved the remaining
app/components/common/Tableleaf cluster intopackages/shared/components/Table(including theuseRowDirectionhook andNTagCellutilities). - Updated OrganismView sections and ConfigureWorkflowInputs table column definitions to consume the shared
Table/NTagCellutilities via@repo/shared/...imports. - Cleaned up type-only imports (
import type) for TanStack Table and React types within the shared Table implementation.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/components/Table/types.ts | Converts TanStack imports to import type for shared Table props typing. |
| packages/shared/components/Table/table.tsx | Uses type-only imports for RowData/Props while keeping runtime behavior intact. |
| packages/shared/components/Table/hooks/UseRowDirection/hook.ts | Adds the shared useRowDirection hook to keep responsive row direction logic within the shared Table cluster. |
| packages/shared/components/Table/components/TableCell/components/NTagCell/utils.tsx | Converts TanStack + React props imports to type-only imports and keeps JSX import consistent with repo usage. |
| app/views/OrganismView/components/Main/components/PangenomeSection/pangenomeSection.tsx | Repoints Table import to the shared package. |
| app/views/OrganismView/components/Main/components/AssembliesSection/assembliesSection.tsx | Repoints Table import to the shared package. |
| app/components/Entity/components/ConfigureWorkflowInputs/.../AssemblySelector/hooks/UseTable/columnDef.ts | Repoints NTagCell utilities import to the shared package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…#1516) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
frano-m
force-pushed
the
fran/table-consolidate
branch
from
July 24, 2026 06:41
dfb77dd to
b4283b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1516.
Completes the shared
Tableto match the reference consolidatedcomponents/Table— moves theapp/components/common/Table/cluster (deferred from the initial Table move) into the existingpackages/shared/components/Table/.Changes
git mvintopackages/shared/components/Table/(merges with the cells +table.styles.tsalready there):table.tsx,types.ts,hooks/UseRowDirection/hook.ts,components/TableCell/components/NTagCell/utils.tsx.import typetidy:RowData/Props(table.tsx),RowData/Table(types.ts),CellContext/RowData/ComponentProps(NTagCell).JSXleft unprefixed per repo convention.@repo/shared/components/Table/…: OrganismViewAssembliesSection+PangenomeSection(theTablecomponent), ConfigureWorkflowInputsAssemblySelector/columnDef(NTagCell).Clean leaf cluster — no
@//@site-configdeps, no union types.Notes
git mvreorg — no behaviour change, so no new tests.app/components/Docs/.../common/Tableis a different (Docs) component and is untouched.Verification
@/components/common/Tableimports remain;app/components/common/Table/removed; moved code has no@//@site-configimports (shared purity).tsc --noEmit, eslint, prettier: clean. Unit tests: 581/581.build:local: succeeds.🤖 Generated with Claude Code