feat: improve schema descriptions (#375) #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunterckx
requested changes
May 25, 2025
catalog/schema/organisms.yaml
Outdated
| attributes: | ||
| taxonomy_id: | ||
| description: The organism's NCBI taxonomy ID. | ||
| description: An NCBI Taxonomy ID. If non-null, all assemblies which have this ID as part of their taxonomic lineage will display this workflow. |
There was a problem hiding this comment.
Looks like this needs to be fixed to describe the taxonomy_id field for organisms rather than for workflows. Everything else looks good to me!
|
(This will probably also need to be updated from main now that #542 is merged, if only so that the generated schema files can be rebuilt) |
hunterckx
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #375