feat: update sunburst colors (#482) #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I wonder if we should include licensing information or more explicit attribution for the colors? Common wisdom seems to be that color palettes can't be copyrighted, so quite possibly this doesn't apply if it's the same colors but different code, but Crameri's palettes appear to be distributed with an MIT license: https://zenodo.org/records/8409685 |
|
i dont think its strictly necessary.. what did you have in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #482
adds some fun color-deficient friendly color maps (happy to put those somewhere else if theres a better place) that we can use in this or any other vizs we like. also updates the sunburst to use one of those color maps without repeating colors or using gray for one of the top tier children.