[25.0] Replace Bootstrap Popover with Popper wrapper #20246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to allow navigation from reference to popper
guerler
added
release-testing-25.0
mvdbeek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20237. The issue described in the ticket appears to stem from a bug in the Bootstrap popover component. This PR replaces it with our own Popper wrapper, giving us more control over its behavior. It also adds tests. While we could further improve the LoginRequired component by using references, and clean up the grid components by moving the popover outside the parent divs, these changes are not critical for now.
How to test the changes?
(Select all options that apply)
License