-
Notifications
You must be signed in to change notification settings - Fork 1k
Split Login and Register, enable OIDC Registration. #20287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
uwwint
wants to merge
20
commits into
galaxyproject:dev
Choose a base branch
from
uwwint:change/login_register
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the login page to not break test. This could be optimized further
…rd fields and login buttons
…vider and push it tothe frontend
… testing with Custos/CILogon
…ocal accounts is disabled.
…n defined, push the user off to the configured registration.
…en clicking on login.
45dd95e
to
ffb8792
Compare
Thanks for these changes @uwwint !!! Will try out all the use cases you've added next! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the ability to configure OIDC registration endpoints. In order to achieve this functionality Login and Register need to be split. The new functionality will do the following:
Add enduser registration endpoint to oidc_backends.xml
Expose them in /api/configuration
Add a galaxy configuration option to disable local accounts
Change the frontend to:

a. Split Login / Registration into two buttons
b. In case only one OIDC provider is configured and local accounts are disabled, Login will redirect the user to the OIDC endpoint.

In case local accounts are enabled the behavior of previous galaxy is retained.
c) In case local accounts are disabled and one OIDC provider with end user registration endpoint exists register will redirect the user straight to the registration of the OIDC provider.
In case no OIDC provider with end user registration is configured and local accounts are disabled, or local registration is disabled in galaxy.yml, registration is not shown on the UI (as per current behavior)
If more than one OIDC provider with an endpoint are defined, or local accounts are enabled the Registration page will show all options.
How to test the changes?
(Select all options that apply)
In order to test oidc registration, or disabling local accounts manual testing is still required. The best way is to test the following:
License