Skip to content

Switch default visualization type to new frameworks script entry point #20303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

guerler
Copy link
Contributor

@guerler guerler commented May 20, 2025

Requires #20348. This PR changes the default visualization type from Mako to the new script-based entry point. Currently, only two Mako-based visualizations remain: (1) Trackster, (2) MVPApp and (3) HIVTrace. Once these are migrated, the Mako entry point can be fully removed. Dropping Mako support soon will help streamline the visualization registry.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 25.1 milestone May 20, 2025
@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels May 20, 2025
@guerler guerler force-pushed the switch_default_visualization branch from 39e2a48 to 00f152e Compare May 25, 2025 22:03
@guerler guerler marked this pull request as ready for review May 25, 2025 22:07
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so the logo is now also part of the npm app?

@@ -0,0 +1,30 @@
aceeditor:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ID here does it need to match the vis-id in the XML? Maybe add a small comment on top?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id is aceeditor and the name is Editor, the latter is shown to the user in the title of the visualization.

@guerler guerler force-pushed the switch_default_visualization branch from 373e307 to db117fb Compare May 26, 2025 18:58
@guerler guerler marked this pull request as draft May 26, 2025 19:00
@guerler guerler force-pushed the switch_default_visualization branch from db117fb to 5e740b7 Compare May 26, 2025 19:02
@guerler guerler marked this pull request as ready for review May 26, 2025 19:02
@guerler guerler force-pushed the switch_default_visualization branch from fe5a700 to c1280cb Compare May 28, 2025 22:41
@guerler guerler marked this pull request as draft May 29, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants