-
Notifications
You must be signed in to change notification settings - Fork 1k
Switch default visualization type to new frameworks script entry point #20303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
39e2a48
to
00f152e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, so the logo is now also part of the npm app?
client/visualizations.yml
Outdated
@@ -0,0 +1,30 @@ | |||
aceeditor: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ID here does it need to match the vis-id in the XML? Maybe add a small comment on top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id
is aceeditor
and the name
is Editor
, the latter is shown to the user in the title of the visualization.
373e307
to
db117fb
Compare
db117fb
to
5e740b7
Compare
fe5a700
to
c1280cb
Compare
Requires #20348. This PR changes the default visualization type from Mako to the new script-based entry point. Currently, only two Mako-based visualizations remain: (1) Trackster, (2) MVPApp and (3) HIVTrace. Once these are migrated, the Mako entry point can be fully removed. Dropping Mako support soon will help streamline the visualization registry.
How to test the changes?
(Select all options that apply)
License