Skip to content

[25.0] Add basic validation to workflow creator attribute #20328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented May 21, 2025

Fixes #20314

We don't check for duplicate values here because this would require not only a comparison of the full set of a creator's fields to the fields of existing creators, but also adding a disambiguation policy for cases when those fields have identical values, which is ..not worth the effort.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 25.1 milestone May 21, 2025
@jdavcs jdavcs requested a review from a team May 21, 2025 22:38
@ahmedhamidawan ahmedhamidawan modified the milestones: 25.1, 25.0 May 22, 2025
@jdavcs jdavcs merged commit 4294ac0 into galaxyproject:release_25.0 May 28, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants