Skip to content

[25.0] [WIP] DatasetView and Card Polish #20342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: release_25.0
Choose a base branch
from

Conversation

dannon
Copy link
Member

@dannon dannon commented May 23, 2025

WIP, iterating on smoothing out user interactions with the new streamlined view.

Tests will fail here with the removal of two icons from the card.

xref #20301

Adjusted header:
Nicer formatting, dropped 'info', which folks agreed was usually cluttered with unhelpful stderr.
We keep 'blurb'.
image

For the card options, eye and error are dropped and we're going with a new icon.

Here's faExpand:
image

And here's ScanEye:
image

I'm also going to mock up a quick composite of faEye and faExpand (which will be a lot like ScanEye, but with fa styles) in a sec.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot changed the title [WIP] DatasetView and Card Polish [25.0] [WIP] DatasetView and Card Polish May 23, 2025
@bgruening
Copy link
Member

Thanks @dannon for working on this. Can we maybe postponing the changes to the Dataset Card? Imho it's way too late to change this now, and we should bring back the i symbol as well for this release. Those are fundamental buttons that we have (probably?) for 20 years. We need to coordinate this and update many places and documentations ... its a large effort downstream - that I don't see happening in the next 2 month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants