Skip to content

fix pinned-requirements: using ssh for download #20352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

jianzuoyi
Copy link

Sometimes downloading files from GitHub via HTTPS doesn't work, but using SSH does.

Therefore, it's better to specify the SSH method in the pinned-requirements file.

@github-actions github-actions bot added this to the 25.1 milestone May 26, 2025
@nsoranzo
Copy link
Member

This file is auto-generated, you need to also modify pyproject.toml .

@nsoranzo
Copy link
Member

Also, all tests fail as you need to authenticate via SSH.

@mvdbeek
Copy link
Member

mvdbeek commented May 28, 2025

I would also say ssh is more likely blocked in corporate environments than https. We might want to publish the package so we don't have to pull from github ?

@jianzuoyi
Copy link
Author

I would also say ssh is more likely blocked in corporate environments than https. We might want to publish the package so we don't have to pull from github ?

Publishing the package is indeed a better approach, as it allows users to download it through multiple channels, such as mirror sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants