Skip to content

[25.0] Small UI fixes for ag-grid based rule grid. #20358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

[25.0] Small UI fixes for ag-grid based rule grid. #20358

merged 1 commit into from
May 28, 2025

Conversation

jmchilton
Copy link
Member

Should fix two issues with the display of this component within the modal including I think #20320.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review May 27, 2025 15:30
@github-actions github-actions bot added this to the 25.1 milestone May 27, 2025
@jmchilton jmchilton merged commit 72f61e4 into galaxyproject:release_25.0 May 28, 2025
27 of 30 checks passed
@github-actions GitHub Actions
Copy link

This PR was merged without a "kind/" label, please correct.

@jmchilton jmchilton mentioned this pull request May 28, 2025
Open
@nsoranzo nsoranzo deleted the rule_grid_fix branch May 28, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
25.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jmchilton @davelopez @nsoranzo