Add DRS compact identifier support #20410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
reviewed
Jun 6, 2025
jmchilton
approved these changes
Jun 6, 2025
Member
jmchilton
left a comment
jmchilton
left a comment
There was a problem hiding this comment.
Very exciting - thanks for the tests!
dannon
force-pushed
the
compact-drs
branch
2 times, most recently
from
f6b199f to
298521a
Compare
dannon
force-pushed
the
compact-drs
branch
2 times, most recently
from
de0f1f3 to
d40e20f
Compare
Contributor
|
This one probably needs a rebase to see if the linting errors are gone |
Member
Author
|
I'm going to rebase this and prune it back to what was approved and not try to do drs-via-filesources in this branch, that will be a followup. |
Support compact identifiers (e.g., drs://drs.anv0:object-id) by resolving prefixes via identifiers.org. Includes caching and tests.
Refactor S3 download logic, add type hints, enhance error handling
Member
Author
|
I need to add a test update back to this I think, then we're good to go. |
The access_id resolution logic now prefers fetching from /access/{id}
when present, so tests need to mock that endpoint rather than providing
inline access_url in the object response.
Galaxy's DRS response can include access_id: None, so we need to check for truthy values, not just key existence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support compact identifiers (e.g., drs://drs.anv0:object-id) by resolving prefixes via identifiers.org. Includes caching and tests.
How to test the changes?
(Select all options that apply)
License