add a link to a tool-tours #21541
Draft
add a link to a tool-tours #21541
+303
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a URL like `?tool_id=addValue&start-tour`, the startTour prop was not being set correctly in ToolForm component.
Root cause:
- Home.vue spreads the entire query object: { ...this.query }
- This includes the kebab-case property: "start-tour": null
- After processing, we set: result.startTour = true
- But both properties exist: result["start-tour"] and result.startTour
- When Vue binds props with v-bind="toolParams", the kebab-case property overrides the camelCase one, causing startTour to receive null
Member
|
@bgruening It should work now. |
Member
Author
|
Cool, I confirm that this is now working. Thanks. |
- Rename variables for improved readability (localTourData -> tourGenerationResult, tourStartVersionKey -> lastProcessedVersion, etc.) - Reorganize code structure by moving watchers after functions - Add descriptive comments to watcher logic - Simplify startTour query parameter handling in Home.vue - Fix formatting and indentation in ToolForm.vue - Reorder imports for consistency
bgruening
commented
Jan 8, 2026
| watch(hasFailedHistoryItems, (hasFailed) => { | ||
| if (hasFailed) { | ||
| Toast.error( | ||
| "This tour uploads datasets that failed to be created. You can try generating the tour again.", |
Member
Author
There was a problem hiding this comment.
Something wrong in this sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to have a URL to a tool-tour. The idea is to have something like
http://localhost:8080/?tool_id=addValue&version=latest&start-tour<-- please note thestart-tour. I have not got this working, buthttp://localhost:8080/?tool_id=addValue&version=latest&start-tour=tis working.Is this going into the correct direction?
ping @kostrykin