Skip to content

Fix parsing user id to preferences #21576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
guerler wants to merge 2 commits into
base: dev
Choose a base branch
from
+7 −6
Draft

Fix parsing user id to preferences #21576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80653df
Fix parsing user id to preferences
guerler Jan 13, 2026
b984135
Remove unused import
guerler Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions client/src/components/User/UserPreferencesForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import { BAlert } from "bootstrap-vue";
import { storeToRefs } from "pinia";
import { computed, ref, watchEffect } from "vue";
import { useRouter } from "vue-router/composables";

import { isRegisteredUser } from "@/api";
import {
Expand All @@ -18,6 +17,7 @@ import LoadingSpan from "@/components/LoadingSpan.vue";

interface Props {
formId: UserPreferencesKey;
id?: string;
}

const props = defineProps<Props>();
Expand All @@ -29,13 +29,11 @@ const breadcrumbItems = computed(() => [{ title: "User Preferences", to: "/user"
const userStore = useUserStore();
const { currentUser } = storeToRefs(userStore);

const router = useRouter();

const loading = ref(true);

const model = computed<UserPreferencesModel | undefined>(() => {
if (router.currentRoute.params.id) {
return getUserPreferencesModel(router.currentRoute.params.id);
if (props.id) {
return getUserPreferencesModel(props.id);
} else if (isRegisteredUser(currentUser.value)) {
return getUserPreferencesModel(currentUser.value.id);
} else {
Expand Down
5 changes: 4 additions & 1 deletion client/src/entry/analysis/router.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,10 @@ export function getRouter(Galaxy) {
{
path: "user/:formId",
component: UserPreferencesForm,
props: true,
props: (route) => ({
formId: route.params.formId,
id: route.query.id,
}),
redirect: redirectAnon(),
},
{
Expand Down
Loading