Skip to content

Conversation

@davelopez
Copy link
Contributor

Follow-up to #21635 (comment)

Unifies the definition of the BootstrapSize type by relocating it to a central module for easier reuse and improved type consistency across components.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Unifies the definition of the BootstrapSize type by relocating it to a central module for easier reuse and improved type consistency across components.
@davelopez davelopez added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jan 30, 2026
@github-actions github-actions bot added this to the 26.1 milestone Jan 30, 2026
@davelopez davelopez marked this pull request as draft January 30, 2026 12:17
@itisAliRH itisAliRH force-pushed the refactor_move_bootstrap_size_type branch from f861e70 to 87e5b63 Compare January 30, 2026 16:18
@itisAliRH itisAliRH force-pushed the refactor_move_bootstrap_size_type branch from 87e5b63 to 51891dd Compare January 30, 2026 16:22
@itisAliRH
Copy link
Member

We cannot replace the size prop in the Heading because Vue 2's prop validation system expects constructors (like String, Number, or validator functions) rather than TypeScript type aliases. We will replace it later then.

@davelopez davelopez marked this pull request as ready for review January 30, 2026 16:45
@itisAliRH
Copy link
Member

The failed test is irrelevant.

@itisAliRH itisAliRH merged commit 47fece7 into galaxyproject:dev Jan 30, 2026
32 of 33 checks passed
@itisAliRH
Copy link
Member

Thank you @davelopez!

@davelopez davelopez deleted the refactor_move_bootstrap_size_type branch February 2, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants