Seed <repeat default=N> only when a request omits the repeat#23170
Draft
guerler wants to merge 2 commits into
Draft
Seed <repeat default=N> only when a request omits the repeat#23170guerler wants to merge 2 commits into
guerler wants to merge 2 commits into
Conversation
guerler
force-pushed
the
toolrequests.004
branch
from
July 26, 2026 12:15
ad953fa to
cf392ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for: #23084, focussing on repeat seeding.
This change ensures repeat parameters consistently honor their declared default value during tool request execution. If a repeat is omitted from the request, the default number of instances is created, if an explicit empty list is provided, zero instances are preserved, and min continues to enforce the minimum number of instances. The default value is clamped to the configured [min, max] range during parsing, matching the parameter model. This prevents tools that rely on default repeat values from receiving malformed inputs while preserving the semantics of structured tool requests.
How to test the changes?
(Select all options that apply)
License