-
Notifications
You must be signed in to change notification settings - Fork 16
Add/changes some mem values #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hm strange error |
tools.yml
Outdated
| mem: 250 | ||
| cores: 2 | ||
| rules: | ||
| - if: 0.05 <= input_size < 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These rules could be given ids, e.g.:
- id: metaspades_medium_input_rule
if: 0.05 <= input_size < 1
That makes it easier to understand where a rule has come from downstream, and also to override a rule on a downstream galaxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also prefix the rule id with tpvdb_?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fine like this? 4026dbb
tools.yml
Outdated
| toolshed.g2.bx.psu.edu/repos/iuc/binette/binette/.*: | ||
| cores: 6 | ||
| mem: 32 | ||
| toolshed.g2.bx.psu.edu/repos/iuc/fastp/fastq/.*: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not look like it matches a tool ID. The shared db already has an entry for toolshed.g2.bx.psu.edu/repos/iuc/fastp/fastp/.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i had a typo there but yes you are right there was a rule strange i didnt found it at the beginning. 45309ff removed it here and change the entry to have at least 8 GB at the beginning instead of only 3.7
Co-authored-by: cat-bro <[email protected]>
|
@SantaMcCloud Thanks for this. Could you also please run tpv format to fix the linting error? |
|
@nuwang should be done! |



I check some mem between
.ORG,.FRand.EUfor some tools which are used in a WF.After comapre them i got ask to change some mem or add some tools/rules to the shared db.
I copy metaSPAdes and Semibin from
.EU: https://github.com/usegalaxy-eu/infrastructure-playbook/blob/59ae3e284aa1ea32ebb1d9f25f0119f5b3821879/files/galaxy/tpv/tools.ymlBinette, CheckM2 and CheckM lineage_wf where copied from
.FR: https://gitlab.com/ifb-elixirfr/usegalaxy-fr/infrastructure/-/blob/preprod/production/files/total_perspective_vortex/tools.yml?ref_type=heads