Skip to content

drop docker requirements for three recetox tools #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martenson
Copy link
Member

these run fine on singularity on UMSA

these run fine on singularity on UMSA
@nuwang
Copy link
Member

nuwang commented May 16, 2025

@martenson Looks like it needs tpv format to be run prior to checkin. Also, should these be considered a breaking change or does it not matter for these tools?

@martenson
Copy link
Member Author

martenson commented May 19, 2025

@nuwang I guess that depends on how that tag is meant... the tool requires a container ( <container type="docker">recetox/qcxms-docker:@TOOL_VERSION@</container>) but the implicitly converted singularity will work fine in our experience. You tell me :)

as of tpv format that does no diff for me locally

❯ diff tools.yml <(tpv format tools.yml)
❯ git status
On branch docker-not-required
Your branch is up to date with 'origin/docker-not-required'.

nothing to commit, working tree clean

@martenson
Copy link
Member Author

It is a bit tricky in a way that the docs suggest to enumerate the container requirements that the tool can be run with: https://docs.galaxyproject.org/en/master/dev/schema.html#tool-requirements-container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants