Skip to content

Update training assembly #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 16, 2025

Conversation

scorreard
Copy link
Contributor

Did a list of changes following live training :

  • Folder name changed (from flye-assembly to hifi-assembly)
  • Time estimation : Reduced the estimated time to 3hr
  • Quast : Reordered the quast with reference genome and the quest without
  • Quast with reference genome : Removed the reference genome as an input (as it is used as the reference)
  • BUSCO : updated version
  • BUSCO : Suggested to use the cached lineage
  • BUSCO : Changed the lineage (and updated the results)

@shiltemann
Copy link
Member

thanks a lot @scorreard! Can I ask why you changed the folder name?

@scorreard
Copy link
Contributor Author

Hi @shiltemann! The folder name was flye-assembly, as flye was the assemble used in the previous training. I updated the training so that users have the choice between 2 assemblers (flye and hifiasm), so it's not just a flye-assembly tuto, hence the change.
HiFi is the read type, not the assembler name, so it fits both assemblers

@shiltemann
Copy link
Member

thanks for explaining, makes sense, one question:

Did you intend for this tutorial to replace the original one, or do you think we should keep both separately? From your explanation it sounds like it should just replace the previous one right, since now you just get an additional choice of tool?

If that is the case, could you please:

  1. Delete the flye-assembly folder

  2. In the metadata of your tutorial, add

    redirect_from:
      - topics/assembly/tutorials/flye-assembly/tutorial
    

    This will make sure that people who had bookmarked the original URL will still end up at the right tutorial, even though we renamed the folder.

    (and we will need to do something similar for the workflows/index.md and faqs/index.md files)

@scorreard
Copy link
Contributor Author

Yes, the idea is to replace the original one as they now have the choice (the original one being one of the choice).

I deleted the folder and added the redirect in the tutorial metadata.

Should I do something in the workflow and faqs even if they are empty?

Thanks!!

@shiltemann
Copy link
Member

shiltemann commented May 15, 2025

Thanks!

For the other redirects:

workflows/index.md file

---
layout: workflow-list
redirect_from:
- topics/assembly/tutorials/flye-assembly/workflows/
---

(and similar for faqs/index.md file)

For the main_workflow.ga workflow file itself, its a little bit different, but you can add a file similar to this one inside the redirects/ folder in the root of the GTN

@scorreard
Copy link
Contributor Author

Great, this should do it?

@shiltemann
Copy link
Member

looks good to me (the tests will let us know if not), thanks!

@shiltemann
Copy link
Member

shiltemann commented May 15, 2025

This looks good from the GTN technical side, perhaps @abretaud would like to review the content?

Copy link
Collaborator

@abretaud abretaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful thanks 🎉

@shiltemann
Copy link
Member

Thanks for having a look @abretaud, all green checkmarks now, so merging, thanks a lot @scorreard!

@shiltemann shiltemann merged commit 7a8e9ef into galaxyproject:main May 16, 2025
3 checks passed
@scorreard scorreard deleted the update_training_assembly branch May 20, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants