-
Notifications
You must be signed in to change notification settings - Fork 962
Update training assembly #6033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update training assembly #6033
Conversation
Included ORCID ID as it is now expected to pass linting.
thanks a lot @scorreard! Can I ask why you changed the folder name? |
Hi @shiltemann! The folder name was flye-assembly, as flye was the assemble used in the previous training. I updated the training so that users have the choice between 2 assemblers (flye and hifiasm), so it's not just a flye-assembly tuto, hence the change. |
thanks for explaining, makes sense, one question: Did you intend for this tutorial to replace the original one, or do you think we should keep both separately? From your explanation it sounds like it should just replace the previous one right, since now you just get an additional choice of tool? If that is the case, could you please:
|
Yes, the idea is to replace the original one as they now have the choice (the original one being one of the choice). I deleted the folder and added the redirect in the tutorial metadata. Should I do something in the workflow and faqs even if they are empty? Thanks!! |
Thanks! For the other redirects:
(and similar for For the |
Great, this should do it? |
looks good to me (the tests will let us know if not), thanks! |
This looks good from the GTN technical side, perhaps @abretaud would like to review the content? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful thanks 🎉
Thanks for having a look @abretaud, all green checkmarks now, so merging, thanks a lot @scorreard! |
Did a list of changes following live training :