-
Notifications
You must be signed in to change notification settings - Fork 962
[New Tutorial] Taxonomic Analysis of eDNA #6055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your conributing @jbeli11!
Just some tiny initial comments about the folder structure:
please remove slashes from your folder names, they are interpreted as subfolders. All your tutorial files should be in a folder like topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/
with inside here directly the tutorial.md file and the workflows
and images
folder
I can also do this for you if you like, just let me know!
...e-analysis/tutorials/Taxonomic Analysis of eDNA/Taxonomic Analysis of eDNA/metadata.yaml.txt
Outdated
Show resolved
Hide resolved
...torials/Taxonomic Analysis of eDNA/Taxonomic Analysis of eDNA/tutorial/data-library.yaml.txt
Outdated
Show resolved
Hide resolved
...sis/tutorials/Taxonomic Analysis of eDNA/Taxonomic Analysis of eDNA/tutorial/tutorial.md.txt
Outdated
Show resolved
Hide resolved
...nalysis of eDNA/Taxonomic Analysis of eDNA/data/eDNA sample data/HP3_S9_L001_R1_001.fastq.gz
Outdated
Show resolved
Hide resolved
data is also hosted on zenodo (https://zenodo.org/records/15367390)
Is this something that can be done within the github interface or would it require reorganizing the folders locally and then reuploading them? Thank you for your help with this! |
@jbeli11 I am not sure if it can be done via the interface to be honest, but I can do it from the commandline for you, since it doesnt make sense to re-upload in my opinion. |
ok, I pushed some changes to apply the re-organisation, depending on how you are using git you may have to do a Let me know if you run into any issues with this, or have any other git questions, it can be a bit of a learning curve if you're new to GitHub and that's totally ok! |
do you know how to resolve the following error:
HTML-Proofer found 1 failure! |
@jbeli11 I think it's just a typo, seems that you used two l's in the CONTRIBUTORS.yaml file (jbelli11 instead of jbeli11), if you fix it in that file the error should go away :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jbeli11!
A couple more minor suggestions from the GTN technical side below. You should be able to just hit the "commit suggestion" button on my comments to automatically apply them (if you agree with them of course)
A general question: have you been able to get a live preview of your tutorial? If not, please have a look at this tutorial to get a preview using CodeSpaces (all online, no installation required)
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
topics/sequence-analysis/tutorials/eDNA-taxonomic-analysis/tutorial.md
Outdated
Show resolved
Hide resolved
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
…orial.md Co-authored-by: Saskia Hiltemann <[email protected]>
Thank you for the valuable input @shiltemann ! |
Would the issues causing the linting to fail be related to the tutorial.md as well or something else that needs troubleshooting? |
Hi John! THANK you for this new training material! Considering the eDNA topic, it can be of interest 1/ to propose this tutorial in the ecology topics 2/ to look at the existing tutorial https://training.galaxyproject.org/training-material/topics/ecology/tutorials/Obitools-metabarcoding/tutorial.html maybe to write some line about similarities and/or differences (and the same can be done on the Obitools tutorial). Please, don't hesitate to say if this can be relevant or not and if I can help somewhere ! I can at least try your tutorial and maybe review it! |
@yvanlebras thanks! I agree it would be nice to move this into the ecology topic, and if you can test the tutorial and review it that would be great! @jbeli11 I will look into the error, might be unrelated to your changes. |
@jbeli11 the linting error came from the data-library.yaml file, so I let our automations re-create it from the Zenodo link. I also moved your tutorial into the ecology topic. @yvanlebras please advise on the best ecology subtopic for this tutorial, and review the scientific content. From a technical perspective this looks good :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and clear tutorial! Thank you!
It is eDNA oriented due to input datasets but in fact it shawos how to use classical tools to look at taxonomic informzations from raw sequencing data.
For a specific comment, maybe it is better to change Count (last tool) How should the results be sorted? *
parameter so it is easier to look at results and evaluate directly the most common sequence identified.
I made a mistake, wanted to propose some modifications, but made it through a direct commit.. Sorry, don't hesitate to change it!
I have written a tutorial for the taxonomic analysis of environmental DNA sequences as part of my master's degree thesis and have added myself as a contributor to be able to submit it for review for approval.