Added search by topic following previous format. #6083
Conversation
search2.html
Outdated
| <label for="topic">Topic</label> | ||
| <select class="form-control" id="topic"> | ||
| <option value="Any">Any</option> | ||
| <option value="Assembly">Assembly</option> |
There was a problem hiding this comment.
we should automatically create these options in a loop, so that when we add new topics they will be automatically supported in the search as well.
you can probably get inspiration from the _layouts/home.html file on how to do it, otherwise I can help out (but I'm away on vacation next week so may only have time after that)
There was a problem hiding this comment.
I can give it a try. Thanks for pointing the right place to look for inspiration. :D
There was a problem hiding this comment.
sure thing, hope it helps, no worries if not. We should have some better documentation for contributing to the technical framework, but never got around to it
There was a problem hiding this comment.
You are too kind. I wish I could work more closely with you.
Thanks to your hint at the right place and with LLMs I think I improved this PR.
There is a problem that I could spot. With the current one I get the followings as topics while they are apparently not:
- SARS-CoV2
- ELIXIR
- GMOD
- One Health
- Plants
I noticed the following topics are also missing in this implementation:
GTN FAQ
Galaxy FAQ
I did a fix. But any collection similar to "Plants" in future will have this problem. So, a smarter fix would be nice.
I noticed that I sometimes cannot find the tutorials I am looking for. Specially, there are topics that I know they exist. I thought maybe it would be nice to add a new filter button to narrow down the results of the search to a specific "Topic".
There is nothing novel in this PR. I copy-pasted almost everything from the file and changed the text. The local test works fine on my laptop. I changed the size of buttons and menus slightly so everything stays in the same line (it was all white space that I saved).