Skip to content

initial commit adding known metabolomics tools #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hechth
Copy link
Contributor

@hechth hechth commented Aug 7, 2024

This pull request adds Metabolomics tools installed and used on usegalaxy.eu and usegalaxy.fr.
Most tools are coming from RECETOX and Workflow4Metabolomics - the tool wrappers are available on the following github repositories:

https://github.com/RECETOX/galaxytools
https://github.com/workflow4metabolomics/tools-metabolomics

Installation sequence for tool-installers

  • Test using @galaxybot test this
  • Inspect CI output for expected changes
  • Deploy using @galaxybot deploy this if test install was successful
  • Merge this PR

@hechth hechth requested a review from a team as a code owner August 7, 2024 12:37
@mvdbeek
Copy link
Member

mvdbeek commented Aug 7, 2024

@galaxybot test this

@martenson
Copy link
Member

Some of these we already have in https://github.com/galaxyproject/usegalaxy-tools/blob/master/usegalaxy.org/training_metabolomics.yml

We should probably consolidate?

@hechth
Copy link
Contributor Author

hechth commented Aug 7, 2024

Oh I didn't see that - yeah we should! Good catch @martenson

@hechth
Copy link
Contributor Author

hechth commented Aug 7, 2024

@martenson the training metabolomics tools are all contained in the longer list that I added now, so I think this should be fine - I just removed the training_metabolomics.yml file and the related lockfile.

@martenson
Copy link
Member

It needs to be consolidated I think. This PR currently drops changesets which are installed on Main. This would desync our state, we generally do not uninstall tools (and this repo is not a way of doing it anyways).

@hechth
Copy link
Contributor Author

hechth commented Aug 9, 2024

Okay, so I would need to have the same versions or how would that work?

@martenson
Copy link
Member

Each revision corresponds to a version so if multiple files have the same repo the unified file has to list all revisions.

  revisions:
  - 545054b15d7c
  - 6153e8ada1ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants