WIP: Remove deprecated features #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pgrill
commented
Aug 2, 2021
pgrill
commented
- Remove area definition
- Remove metrics
- Remove notifications
renzodgc
reviewed
Aug 3, 2021
| """ | ||
| areas = get_areas_to_export(export_info) | ||
| cameras = get_cameras_to_export(export_info, areas) | ||
| cameras = get_cameras_to_export(export_info) |
There was a problem hiding this comment.
will the processors support exporting data from cameras? I don't mind from the API but it might be weird from the frontend (unless the only option is all cameras)
pgrill
force-pushed
the
Remove-Deprecated-Features
branch
from
647eea7 to
c38232c
Compare
pgrill
force-pushed
the
Remove-Deprecated-Features
branch
from
c38232c to
e0f7542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.