chore: drop the live-show plugin - #146
Merged
Merged
Conversation
Removed rather than kept as a draft, because its valuable part is already covered and the rest does not belong in a CI tool. The soak-test half is real: long unattended play catches leaks and slow crashes that a short test run never will. But runtime-test-framework already launches the built player and collects its results, so "run it for a long time unattended" is a duration/soak mode of that command, not a separate plugin - keeping both would mean two things that launch a player and diverge. The remainder does not survive the same test. Streaming the output is broadcast infrastructure, and a scripted or AI-driven attract-mode playthrough needs an agent that can actually play the game - enormous scope, unverifiable here, and impossible to implement honestly rather than leave as another stub. Nothing referenced it: it was never in cli.ts's default load list and had no importers, so this is a clean removal plus a lockfile regeneration. `bun install --frozen-lockfile` still passes.
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
frostebite
added a commit
to game-ci/documentation
that referenced
this pull request
Aug 24, 2026
…ns page Consolidates #586 (docs: plugin catalog for the 14 new game-ci/cli plugins) into this PR instead of merging it separately - #586 targeted docs/03-github-cli/04-configuration-and-plugins.mdx, which this PR renumbers to 05-configuration-and-plugins.mdx (it inserts 04-orchestrate-advanced/), so the two would otherwise collide on the same page under different filenames. Content is updated to match what actually shipped, not #586's original snapshot: - live-show, dev-tunnel, crash-symbol-upload, screen-capture, dedicated-server-provisioning and anti-cheat are removed from the plugin list - the first was dropped entirely (game-ci/cli#146: duplicated runtime-test-framework's player-launching, and the rest of its scope - broadcast, an AI-driven playthrough agent - doesn't belong in a CI tool), the other five were re-implemented as real Orchestrator capabilities rather than plugin skeletons (game-ci/cli#144), and are documented in a new "Not plugins: build-lifecycle capabilities" section instead. - steam-deploy and runtime-test-framework are marked "Implemented, loaded by default" rather than folded in with the drafts - they are real, working commands, just still subject to change. - Added a warning block reflecting game-ci/cli#145: every plugin here is experimental, none are published to npm, and each one warns at runtime (drafts on load, the two implemented ones when their command is actually used). #586 will be closed as superseded once this merges.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
@game-ci/live-showentirely rather than keeping it as a draft.Why
The valuable part is already covered. The soak-test half is real — long unattended play catches leaks and slow crashes a short test run never will. But
runtime-test-frameworkalready launches the built player and collects its results, so "run it for a long time unattended" is a duration/soak mode of that command, not a separate plugin. Keeping both would leave two things that launch a player, free to diverge.The rest doesn't belong in a CI tool. Streaming the output is broadcast infrastructure. A scripted or AI-driven attract-mode playthrough needs an agent that can actually play the game — enormous scope, unverifiable here, and impossible to implement honestly rather than leave as another stub.
Scope
Nothing referenced it — it was never in
cli.ts's default load list and had no importers, confirmed by grepping the repo forlive-show/liveShowoutside its own directory. So this is a clean directory removal plus a lockfile regeneration.bun install --frozen-lockfilepasses;live-showno longer appears anywhere inbun.lock.Follow-up worth having
If you want the soak-test value, it belongs as
--duration/soak support inruntime-test-framework, where the player-launching already lives — one small real feature instead of one large speculative plugin.🤖 Generated with Claude Code