Fix syntax highlighting for function calls with Flow type arguments #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, this would be super nice! @gandm ping? |
mroch
added a commit
to mroch/vscode-language-babel
that referenced
this pull request
Aug 27, 2019
michaelgmcd
pushed a commit
to michaelgmcd/vscode-language-babel
that referenced
this pull request
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Flow, you can call a function an explicitly specify the types for the generics. For example
This PR attempts to update language-babel to support this syntax. It's a little complicated, since the grammar is somewhat ambiguous. For example,
foo < bar > (123)is a valid expression in JavaScript, but Flow interprets it as a call expression with type parameters.