Added lazy load functionality to owlcarousel#2440
Open
thexmanxyz wants to merge 3 commits intogantry:developfrom
Open
Added lazy load functionality to owlcarousel#2440thexmanxyz wants to merge 3 commits intogantry:developfrom
thexmanxyz wants to merge 3 commits intogantry:developfrom
Conversation
Contributor
Author
|
@mahagr Ping on the PR like requested on Gitter.im |
|
When it will be merged into release? |
Contributor
Author
|
You can also try my version of owl carousel @01Kuzma. Or you can simply override the default particle with my changes. |
Contributor
Author
|
@01Kuzma https://github.com/thexmanxyz/Owl-Carousel-Neo-Gantry It supports lazy load. |
|
thexmanxyz, thank you! |
Contributor
Author
|
You are welcome @01Kuzma |
mahagr
requested review from
hexplor and
simmonsr
and removed request for
newkind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mahagr @newkind @yellowwebmonkey
I think that also other people in the commmunity are missing the lazy load functionality of OwlCarousel2 like me. Moreover, since Google PageSpeed now uses Lighthouse to judge / rate websites (which also includes a check for hidden - lazy loaded images) there should be at least the possibility to provide the option within the Particle. Especially useful since it is often placed on the entry page of a website.
As the original JS library already supports this functionality through API parameters I decided to adapt the Particle and provide you a PR with the working implementation.
Two new options were added: