Added planned / timed slides to owlcarousel#2441
Open
thexmanxyz wants to merge 5 commits intogantry:developfrom
Open
Added planned / timed slides to owlcarousel#2441thexmanxyz wants to merge 5 commits intogantry:developfrom
thexmanxyz wants to merge 5 commits intogantry:developfrom
Conversation
Contributor
Author
|
Just FYI on caching, the static caching is meant to use on a content that is known never to change (unless the particle gets saved). |
Contributor
Author
|
@mahagr Alright, so we need to remove caching here to avoid issues (make it even work). In the meantime I also tested that with some events and can also confirm that. I will prepare a commit in the next minutes. Thanks for the additional feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@newkind @mahagr
This PR can be seen as an addition to a previous merged PR (#2286) where I added the disable functionality for owlcarousel slides. I now had the time to create a more sophisticated solution for the Particle which I already had in mind for months.
It is fine to have slides that can be disabled on demand but even better for maintenance of a websites would be to have specific time intervals to show slides. However, that still wasn't enough, it should be possible to define recurring events (e.g. new year, x-mas, holidays, whatever) and not only within a specific one-time frame.
Therefore I extended the previous behaviour so it is still possible to enable / disable items like before. Additionally, I added two improved options which allow us to show slides on a one-time or an annually event basis. To sum things up we have now the following options to show slides:
PS.: all edge cases should be covered like one-day events, empty start or end-dates as well as year leaps