julia-gc: Time collections without going through SyTime - #6531
Merged
Conversation
The pre and post GC hooks called SyTime to accumulate GC time. SyTime raises a GAP error when the clock cannot be read, and entering the error handler mid-collection runs GAP code, which the collector must not do. getrusage cannot realistically fail with these arguments, so this has never fired, but the collector should not depend on that. Read the clock directly and report 0 if it is unavailable. The Julia GC is only built on systems that provide getrusage; a native Windows port would have larger problems than this. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6531 +/- ##
==========================================
- Coverage 79.02% 78.99% -0.03%
==========================================
Files 685 685
Lines 294329 294333 +4
Branches 8647 8671 +24
==========================================
- Hits 232601 232520 -81
- Misses 59922 60005 +83
- Partials 1806 1808 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lgoettgens
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre and post GC hooks called SyTime to accumulate GC time. SyTime raises a GAP error when the clock cannot be read, and entering the error handler mid-collection runs GAP code, which the collector must not do.
getrusage cannot realistically fail with these arguments, so this has never fired, but the collector should not depend on that. Read the clock directly and report 0 if it is unavailable. The Julia GC is only built on systems that provide getrusage; a native Windows port would have larger problems than this.
Co-authored-by: Claude Opus 5 noreply@anthropic.com