forked from erlang/otp
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from erlang:master #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the files have been manually checked and where created by members of OTP. the addition of SPDX notation at the header was performed using REUSE tool.
The erl.ini file is no longer needed as Windows can figure out everything it needs by using the C API. We keep support for it as they are convinient when running erlang in the source/bootstrap tree.
PCRE2 source files imported as-is from branch ERLANG_INTEGRATION in forked pcre2 repo; commit 1535e2154cbc76532948d9ef8bdf3c24e74c67dd The test files testoutput* has also been copied from pcre2 repo and the parsing in run_pcre_tests.erl updated to handle the slightly different syntax and options described at https://www.pcre.org/current/doc/html/pcre2test.html. Test file mod_testoutput8 only updated to conform with the new syntax. Don't know the origin story of that file. Also improved the generation of files re_testoutput1_replacement_test.erl and re_testoutput1_split_test.erl by run_pcre_tests.erl Co-authored-by: Fredrik Frantzen <[email protected]>
Perl version 5.34.0 was used. The default installed on ELX 6 Ubuntu 22.04.5 LTS.
I give up. This is such a contrived test. I doubt there even is a sane result that anyone would expect.
Does not compile on old PCRE. It says "an argument is not allowed for (*ACCEPT), (*FAIL), or (*COMMIT)" Difference in PCRE2 10.44 vs perl 5.34.0 Perl matches "axabc" as "a(*COMMIT)b" PCRE2 does not match.
Does no compile on old PCRE. It says "lookbehind assertion is not fixed length" Difference in PCRE2 10.44 vs perl 5.34.0 Perl complains on stderr: "Variable length lookbehind is experimental in regex..." and returns strange match results.
Initial version
Also no unnecessary and ugly memcpy of pcre2_code which was done for every re:run call with precompiled regex.
Autoskip when run options are incompatible with compile options, ie mismatching {newline,_} and bsr_* options.
Changed from nomatch to match \p{Lo} \x{4db6} \p{Arabic} \x{061c}, \x{650-655} Changed from match to nomatch \p{Common} \x{589}
PCRE2 does not like empty capture group names "(?''...)"
PCRE2 compile error: "length of lookbehind assertion is not limited"
Don't understand why this didn't match in PCRE It should match either "bn" or "bnn" depending on the condition (?=b(*SKIP)a) which I don't truly understand. But "bnn" matches both "bn" and "bnn", so...?
The error message has changed in PCRE2.
Co-authored-by: Rickard Green <[email protected]>
…-licenses/OTP-19478 Add missing licenses OTP-19478
* lukas/erts/fix-erlexec_SUITE-cross-compile: erts: Cannot include eunit using include_lib in cross env
…-19478 Add missing wxWindows-free-doc license and fix other licenses OTP-19478
Renable optimization for appending 0 bits to a binary
* lukas/erts/enif_scheduler_pollset/OTP-19479: erts: Expand debug printout in check io erts: Add scheduler polling support to nifs erts: Refactor check_io to simplify state flags handling erts: Add Check I/O internal documentation otp: Fix type and flavor handling when running tests
* lukas/stdlib/zstd/OTP-19477: gh: Create sbom on scheduled builds stdlib: Add zstd module otp: Polish printouts of scan-code
* lukas/erts/windows-remove-erl.ini/OTP-19481: erts: Remove erl.ini from Windows release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We failed to fetch the diff for pull request #208
You can try again by commenting this pull request with @sourcery-ai review
, or contact us for help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )