Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from erlang:master #209

Merged
merged 5 commits into from
Feb 7, 2025
Merged

[pull] master from erlang:master #209

merged 5 commits into from
Feb 7, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 7, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Build:

  • Change debug CFLAGS from -O0 to -Og.

sverker and others added 5 commits February 7, 2025 10:25
to improve performance with hopefully unreduced debugability.
Build debug emulator with -Og instead of -O0
If we don't do this, then rapidly triggered FDs can end up being cleared
by the previous marker instead of being moved the the scheduler pollset.
* lukas/erts/enif_scheduler_pollset/OTP-19479:
  erts: Clean scheduler data when enif_select is called
@pull pull bot added the ⤵️ pull label Feb 7, 2025
@pull pull bot merged commit f4f2d1a into garazdawi:master Feb 7, 2025
Copy link

sourcery-ai bot commented Feb 7, 2025

Reviewer's Guide by Sourcery

This pull request integrates several improvements across the Erlang runtime system. The changes include enhancements to debug logging, memory allocation and variable initialization, better handling of scheduler state in NIF selections, improved assertions in tree search, and updated compiler debug flags. Overall, the modifications refine diagnostic outputs and ensure more robust and safe code behavior.

Updated Class Diagram: ErtsSchedulerData Modifications (Class Diagram)

classDiagram
    class ErtsSchedulerData {
      +int no
      +ErtsSysFdType[] nif_select_fds
      +... // other attributes
    }

    note for ErtsSchedulerData "PR modification: clears the NIF select marker in scheduler data to avoid re-trigger issues; improves runtime safety."
Loading

File-Level Changes

Change Details Files
Enhanced debug logging and scheduler handling in event I/O checks.
  • Updated the DEBUG_PRINT macro to include an additional count parameter for better traceability.
  • Modified the event state flag conversion by removing redundant flag combinations.
  • Added a loop to clear the NIF_SELECT marker from scheduler data to prevent premature re-triggering of file descriptors.
erts/emulator/sys/common/erl_check_io.c
Refactored memory pointer initialization and loop structure in tuple creation.
  • Replaced the global heap pointer with a locally declared variable during heap allocation.
  • Adjusted the loop indentation and structure to properly assign values while converting list elements.
erts/emulator/beam/bif.c
Fixed tracer initialization in process spawn tracing.
  • Initialized the mfa variable properly by assigning a default non-value.
  • Modified the conditional allocation to use a locally defined heap pointer to avoid using an uninitialized pointer.
erts/emulator/beam/erl_trace.c
Improved debug assertions in binary tree search routines.
  • Introduced a debug sentinel value for the 'lastobj' variable to detect invalid states.
  • Added an assertion to ensure that 'lastobj' was properly updated after traversal.
erts/emulator/beam/erl_db_tree.c
Updated compiler debug flags for optimized debugging builds.
  • Changed DEBUG_CFLAGS in the configure script from '-O0' to '-Og' to enable optimizations that benefit debugging.
erts/configure.ac
Added macro calls to ensure proper variable initialization and avoid undefined behavior.
  • Inserted an ERTS_UNDEF call for the 'reason' variable in the process signal queue handling.
  • Added an ERTS_UNDEF call for the 'last' pointer in persistent monitor messages.
  • Introduced an ERTS_UNDEF call for the 'saved_used_size' variable in the NIF environment debugging function.
  • Included an ERTS_UNDEF call for the 'cdir' variable inside the red-black tree traversal debug block.
erts/emulator/beam/erl_proc_sig_queue.c
erts/emulator/beam/erl_nif.c
erts/emulator/beam/erl_rbtree.h
Metadata update in the configuration file.
  • Minor or automatic configuration file adjustments that were recorded without specific code changes.
erts/configure

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants