Skip to content

feat(core): make task concurrency limits configurable via env vars #8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marklester wants to merge 1 commit into
base: 0.13
Choose a base branch
from
+13 −2
Open

feat(core): make task concurrency limits configurable via env vars #8073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ export const gardenEnv = {
GARDEN_DISABLE_VERSION_CHECK: env.get("GARDEN_DISABLE_VERSION_CHECK").required(false).asBool(),
GARDEN_ENABLE_PROFILING: env.get("GARDEN_ENABLE_PROFILING").required(false).default("false").asBool(),
GARDEN_ENVIRONMENT: env.get("GARDEN_ENVIRONMENT").required(false).asString(),
GARDEN_EXECUTE_CONCURRENCY_LIMIT: env.get("GARDEN_EXECUTE_CONCURRENCY_LIMIT").required(false).asInt(),
GARDEN_GE_SCHEDULED: env.get("GARDEN_GE_SCHEDULED").required(false).asBool(),
GARDEN_GIT_SCAN_MODE: env
.get("GARDEN_GIT_SCAN_MODE")
Expand All @@ -99,6 +100,7 @@ export const gardenEnv = {
GARDEN_SERVER_PORT: env.get("GARDEN_SERVER_PORT").required(false).asPortNumber(),
GARDEN_SERVER_HOSTNAME: env.get("GARDEN_SERVER_HOSTNAME").required(false).asUrlString(),
GARDEN_SKIP_TESTS: env.get("GARDEN_SKIP_TESTS").required(false).default("").asString(),
GARDEN_STATUS_CONCURRENCY_LIMIT: env.get("GARDEN_STATUS_CONCURRENCY_LIMIT").required(false).asInt(),
GARDEN_HARD_CONCURRENCY_LIMIT: env.get("GARDEN_HARD_CONCURRENCY_LIMIT").required(false).default(50).asInt(),
GARDEN_WORKFLOW_RUN_UID: env.get("GARDEN_WORKFLOW_RUN_UID").required(false).asString(),
GARDEN_CLOUD_DOMAIN: env.get("GARDEN_CLOUD_DOMAIN").required(false).asUrlString(),
Expand Down
13 changes: 11 additions & 2 deletions core/src/tasks/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import {
import { styles } from "../logger/styles.js"
import type { ActionRuntime } from "../plugin/base.js"
import { deline } from "../util/string.js"
import { gardenEnv } from "../constants.js"

export function makeBaseKey(type: string, name: string) {
return `${type}.${name}`
Expand Down Expand Up @@ -659,11 +660,19 @@ export abstract class ExecuteActionTask<
protected defaultStatusConcurrencyLimit = 10

override get executeConcurrencyLimit(): number {
return this.action.executeConcurrencyLimit || this.defaultExecuteConcurrencyLimit
return (
gardenEnv.GARDEN_EXECUTE_CONCURRENCY_LIMIT ||
this.action.executeConcurrencyLimit ||
this.defaultExecuteConcurrencyLimit
)
}

override get statusConcurrencyLimit(): number {
return this.action.statusConcurrencyLimit || this.defaultStatusConcurrencyLimit
return (
gardenEnv.GARDEN_STATUS_CONCURRENCY_LIMIT ||
this.action.statusConcurrencyLimit ||
this.defaultStatusConcurrencyLimit
)
}

abstract override readonly type: Lowercase<T["kind"]>
Expand Down