Fixed create disabled for some scenarios

Added alert with error message in case no nodes are available to schedule terminal

Author: grolu

backend/lib/services/terminals/index.js

@@ -774,7 +774,8 @@ async function getTerminalConfig ({ user, namespace, name, target }) {
     },
   }
 
-  if (target === TargetEnum.SHOOT) {
+  if (target === TargetEnum.SHOOT ||
+     (target === TargetEnum.GARDEN && !isAdmin)) {
     const shootRef = {
       namespace,
       name,

frontend/src/components/dialogs/GCreateTerminalSessionDialog.vue

@@ -39,7 +39,6 @@ SPDX-License-Identifier: Apache-2.0
           <g-terminal-target
             v-model="targetTab.selectedTarget"
             :disabled="targetTab.configLoading"
-            @update:model-value="updateSettings"
           />
           <v-expansion-panels
             v-model="targetTab.value"
@@ -57,7 +56,7 @@ SPDX-License-Identifier: Apache-2.0
                 <g-terminal-settings
                   v-show="!targetTab.configLoading"
                   ref="settings"
-                  :runtime-settings-hidden="!hasShootWorkerGroups || targetTab.selectedTarget !== 'shoot'"
+                  :runtime-settings-hidden="!hasShootWorkerGroups || targetTab.selectedTarget !== TargetEnum.SHOOT"
                 />
               </v-expansion-panel-text>
             </v-expansion-panel>
@@ -91,10 +90,8 @@ SPDX-License-Identifier: Apache-2.0
     </template>
     <template #footer>
       <v-alert
-        v-if="!isAdmin
-          && targetTab.selectedTarget === 'garden'"
-        class="mt-2 mb-2"
-        :value="true"
+        v-if="showUserGardenTerminalAlert"
+        class="ma-2"
         type="info"
         color="primary"
         variant="tonal"
@@ -103,19 +100,24 @@ SPDX-License-Identifier: Apache-2.0
         Make sure that only gardener project members with <span class="font-family-monospace">admin</span> role have privileged access to the <span class="font-family-monospace">{{ shootName }}</span> cluster before creating this terminal session.
       </v-alert>
       <v-alert
-        v-if="isAdmin
-          && targetTab.selectedTarget === 'shoot'
-          && !targetTab.configLoading
-          && state.runtime === 'shoot'"
-        class="ml-6 mt-6 mb-2"
-        :model-value="true"
+        v-if="showAdminShootTerminalAlert"
+        class="ma-2"
         type="info"
         color="primary"
         variant="tonal"
       >
         <strong>Terminal will be running in an untrusted environment!</strong><br>
         Do not enter credentials or sensitive data within the terminal session that cluster owners should not have access to, as the terminal will be running on one of the worker nodes.
       </v-alert>
+      <v-alert
+        v-if="createDisabledNoNodes"
+        class="ma-2"
+        type="error"
+        variant="tonal"
+      >
+        <strong>Cannot schedule terminal on<span class="font-family-monospace">{{ shootName }}</span> cluster</strong><br>
+        No worker nodes available in the cluster. Please check the cluster status and try again.
+      </v-alert>
     </template>
   </g-dialog>
 </template>
@@ -189,6 +191,7 @@ export default {
       config,
       state,
       updateState,
+      TargetEnum,
     }
   },
   data () {
@@ -223,11 +226,8 @@ export default {
             return false
           }
 
-          if (this.targetTab.selectedTarget === 'shoot') {
-            if (this.config.preferredHost === 'shoot' &&
-             !this.state.shootNodes.length) {
-              return false
-            }
+          if (this.createDisabledNoNodes) {
+            return false
           }
           return !this.v$.$invalid
         }
@@ -264,6 +264,26 @@ export default {
         }
       }
     },
+    showUserGardenTerminalAlert () {
+      return !this.isAdmin && this.targetTab.selectedTarget === TargetEnum.GARDEN
+    },
+    showAdminShootTerminalAlert () {
+      return this.isAdmin &&
+          this.targetTab.selectedTarget === TargetEnum.SHOOT &&
+          !this.targetTab.configLoading &&
+          this.state.runtime === TargetEnum.SHOOT
+    },
+    createDisabledNoNodes () {
+      if (this.state.runtime !== TargetEnum.SHOOT && this.state.runtime !== TargetEnum.GARDEN) {
+        return false
+      }
+      if (this.isAdmin && this.targetTab.selectedTarget === TargetEnum.GARDEN) {
+        // Admin Garden Terminal always scheduled on dedicated managed seed
+        return false
+      }
+
+      return !this.targetTab.configLoading && !this.state.shootNodes.length
+    },
   },
   watch: {
     isSettingsExpanded () {
@@ -279,6 +299,8 @@ export default {
     },
     defaultTarget (value) {
       this.targetTab.selectedTarget = value
+    },
+    'targetTab.selectedTarget' () {
       this.updateSettings()
     },
   },

frontend/src/composables/useTerminalConfig.js

@@ -66,6 +66,7 @@ export function createTerminalConfigComposable () {
     shootNodes: [],
     privilegedMode: false,
     runtime: 'shoot',
+    canScheduleOnSeed: false,
   })
 
   function isAutoSelectNode (hostname) {

frontend/src/composables/useTerminalSplitpanes.js

@@ -87,7 +87,7 @@ export function createTerminalSplitpanesComposable () {
   })
 
   const canScheduleOnSeed = computed(() => {
-    return get(shootItem.value, ['info', 'canLinkToSeed'])
+    return get(shootItem.value, ['info', 'canLinkToSeed'], false)
   })
 
   const slotItemUUIds = computed(() => {
@@ -96,11 +96,13 @@ export function createTerminalSplitpanesComposable () {
   })
 
   const defaultTarget = computed(() => {
-    return terminalCoordinates.value.target ||
-     (authzStore.hasControlPlaneTerminalAccess &&
-      canScheduleOnSeed.value)
-      ? TargetEnum.CONTROL_PLANE
-      : TargetEnum.SHOOT
+    if (terminalCoordinates.value.target) {
+      return terminalCoordinates.value.target
+    }
+    if (authzStore.hasControlPlaneTerminalAccess && canScheduleOnSeed.value) {
+      return TargetEnum.CONTROL_PLANE
+    }
+    return TargetEnum.SHOOT
   })
 
   function addSlotItem ({ data = {}, targetId, position } = {}) {