Extend Etcd CR to specify additional env/volumes/volumeMounts in the StatefulSet definition#1319
Open
CaptainIRS wants to merge 1 commit intogardener:masterfrom
Open
Extend Etcd CR to specify additional env/volumes/volumeMounts in the StatefulSet definition#1319CaptainIRS wants to merge 1 commit intogardener:masterfrom
env/volumes/volumeMounts in the StatefulSet definition#1319CaptainIRS wants to merge 1 commit intogardener:masterfrom
Conversation
gardener-prow
Bot
added
do-not-merge/invalid-commit-message
CaptainIRS
force-pushed
the
etcd-cr-fields
branch
from
88c3fd1 to
fa41701
Compare
gardener-prow
Bot
removed
the
do-not-merge/invalid-commit-message
CaptainIRS
force-pushed
the
etcd-cr-fields
branch
from
fa41701 to
5c3e046
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
cla: yes
gardener-prow
Bot
added
the
needs-rebase
Member
|
@CaptainIRS kindly asking you to rebase this PR on master and resolve the conflicts |
CaptainIRS
force-pushed
the
etcd-cr-fields
branch
from
18bea43 to
da0cb8a
Compare
gardener-prow
Bot
removed
the
needs-rebase
Add `env` and `volumeMounts` fields to both `EtcdConfig` and `BackupSpec`, and a `volumes` field to `EtcdSpec` to allow specifying additional environment variables, volume mounts, and volumes in the etcd and backup-restore containers of the StatefulSet definition. Since volumes are a pod-level concept in Kubernetes, `volumes` is placed at `spec.volumes` rather than being duplicated under each container section. Add validations for new fields
CaptainIRS
force-pushed
the
etcd-cr-fields
branch
from
da0cb8a to
f58c6ee
Compare
21 tasks
Member
|
/assign |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/area usability
/kind enhancement api-change
What this PR does / why we need it:
Adds new optional fields
envandvolumeMountsto bothspec.etcdandspec.backup, and avolumesfield tospecin the Etcd CR. These fields allow specifying additional environment variables, volume mounts, and volumes to be added to the etcd and backup-restore containers in the StatefulSet definition. Since volumes are a pod-level concept in Kubernetes, thevolumesfield is placed atspec.volumesrather than being duplicated under each container section.This provides more options to customize the StatefulSet spec for use-cases like Gardener's Self-Hosted Shoot Clusters.
Which issue(s) this PR fixes:
Fixes #1317
Checklist:
/docsfolder (if applicable)Special notes for your reviewer:
POD_NAME, provider credentials) take precedence since they appear first in the slice.spec.volumes) are pod-level, matching Kubernetes semantics. They are appended after controller-managed volumes in both the StatefulSet builder and the compaction job.Release note:
Etcd CR now supports `spec.etcd.{env,volumeMounts}`, `spec.backup.{env,volumeMounts}`, and `spec.volumes` fields to specify additional environment variables, volume mounts, and volumes for the etcd and backup-restore containers in the StatefulSet.