Allow migration from dual-stack [IPv4, IPv6] to single stack [IPv4] networking#1481
Merged
kon-angelo merged 2 commits intogardener:masterfrom Sep 18, 2025
Merged
Conversation
gardener-robot
added
area/networking
gardener-robot-ci-2
added
the
reviewed/ok-to-test
github-actions
Bot
added
needs/ok-to-test
hebelsan
requested changes
Sep 18, 2025
| "useWorkloadIdentity": useWorkloadIdentity, | ||
| } | ||
| enabled := mode != "ipv4" | ||
| enabled := mode != "ipv4" || utils.HasIPv6NodeCIDR(cluster.Shoot.Status.Networking.Nodes) |
Contributor
There was a problem hiding this comment.
Could a nil pointer access happen here?
I think we should check for that to be on the safe side.
It could even be done in HasIPv6NodeCIDR since it's always called with cluster.Shoot.Status.Networking.Nodes.
| @@ -0,0 +1,22 @@ | |||
| package utils | |||
| } | ||
|
|
||
| // HasIPv6NodeCIDR checks if any of the node CIDRs is IPv6 | ||
| func HasIPv6NodeCIDR(nodeCIDRs []string) bool { |
Contributor
There was a problem hiding this comment.
Could you please add some unit tests.
gardener-robot
added
the
size/M
Contributor
|
The recent changes introduce enhancements that better support IPv6 networking configurations in the Gardener AWS extension. Specifically, the update includes utility functions that aid in determining IPv6 support by inspecting node CIDR configurations. These changes improve the decision-making process around feature enablement in the control plane and ensure optimal configuration without relying solely on predefined networking specifications. Walkthrough
Model: gpt-4o | Prompt Tokens: 1858 | Completion Tokens: 142 |
gardener-robot
removed
the
size/S
gardener-robot-ci-2
added
the
reviewed/ok-to-test
github-actions
Bot
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
github-actions
Bot
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
/platform aws
What this PR does / why we need it:
PR is needed for gardener/gardener#12967
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: