Skip to content

Clean up MCM RBAC resource migrations#1492

Merged
hebelsan merged 1 commit intogardener:masterfrom
georgibaltiev:cleanup/remove-mcm-roles
Oct 1, 2025
Merged

Clean up MCM RBAC resource migrations#1492
hebelsan merged 1 commit intogardener:masterfrom
georgibaltiev:cleanup/remove-mcm-roles

Conversation

@georgibaltiev
Copy link
Copy Markdown
Contributor

How to categorize this PR?

/area security
/kind cleanup
/platform aws

What this PR does / why we need it:

With the following PR, a migration runnable has been added to the PR, in order to remove RBAC resources that were no longer in use. These migrations were intended to be kept until the release of version 1.64.0.

This PR cleans up the migrations.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
NONE

Release note:


@georgibaltiev georgibaltiev requested a review from a team as a code owner September 29, 2025 06:27
@gardener-robot gardener-robot added the needs/review Needs review label Sep 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

The recent changes involve the removal of code related to RBAC purging for the AWS extension which was scheduled post the release of version 1.64.0. This cleanup enhances code maintainability by eliminating obsolete functionalities and tasks that are no longer required with the newer versions of the software, simplifying the extension's management process.

Walkthrough

  • Refactor: Removed deprecated code responsible for purging RBAC resources related to the machine controller manager after version 1.64.0 release. This code's removal reflects the system's evolution and the migration to newer cleanup mechanisms or approaches, ensuring more efficient resource management.

Model: gpt-4o | Prompt Tokens: 1041 | Completion Tokens: 126

@gardener-robot gardener-robot added area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up platform/aws Amazon web services platform/infrastructure labels Sep 29, 2025
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2025
@gardener-robot gardener-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2025
@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2025
Copy link
Copy Markdown
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 29, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2025
@github-actions github-actions bot removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2025
Copy link
Copy Markdown
Contributor

@hebelsan hebelsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hebelsan hebelsan merged commit f559be9 into gardener:master Oct 1, 2025
82 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Security related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants