Skip to content

Fix/efs ipv6#1675

Merged
gardener-prow[bot] merged 5 commits intogardener:masterfrom
hebelsan:fix/efs-ipv6
Apr 13, 2026
Merged

Fix/efs ipv6#1675
gardener-prow[bot] merged 5 commits intogardener:masterfrom
hebelsan:fix/efs-ipv6

Conversation

@hebelsan
Copy link
Copy Markdown
Contributor

@hebelsan hebelsan commented Feb 2, 2026

How to categorize this PR?

/area quality
/kind bug
/platform aws

What this PR does / why we need it:
This PR fixes EFS support in IPv6-only clusters.

In IPv6 clusters, IPv6 EFS mount targets are now created.
The EFS controller is configured with AWS_EC2_METADATA_SERVICE_ENDPOINT_MODE=IPv6.
Finally, this PR enables the IPv6 IMDS endpoint on the instances when the cluster is IPv6-only.

Which issue(s) this PR fixes:
Fixes #1640

Special notes for your reviewer:

Release note:

Support EFS in IPv6 only cluster.

@gardener-prow gardener-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2026
@ghost ghost added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 2, 2026
@hebelsan
Copy link
Copy Markdown
Contributor Author

hebelsan commented Feb 2, 2026

This PR is in draft until gardener/machine-controller-manager-provider-aws#234 is merged.

@github-actions github-actions Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 2, 2026
This was referenced Feb 2, 2026
Closed
Closed
@kon-angelo kon-angelo self-assigned this Feb 19, 2026
@gardener-prow gardener-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2026
@gardener-ci-robot
Copy link
Copy Markdown
Contributor

gardener-ci-robot commented Mar 25, 2026

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as active with /lifecycle active
  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 25, 2026
@gardener-prow gardener-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2026
@federated-github-access federated-github-access Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 13, 2026
@federated-github-access federated-github-access Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 13, 2026
@hebelsan hebelsan marked this pull request as ready for review April 13, 2026 11:59
@hebelsan hebelsan requested a review from a team as a code owner April 13, 2026 11:59
@gardener-prow gardener-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2026
@hebelsan
Copy link
Copy Markdown
Contributor Author

hebelsan commented Apr 13, 2026

Since the MCM PR has been merged and released, this PR is now ready for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 13, 2026

This change updates the Gardener AWS extension to support IPv6 networking configurations and modernizes the EFS (Elastic File System) client API interactions. The update includes new machine controller manager provider version, IPv6 IMDS (Instance Metadata Service) endpoint configuration, and refactored EFS handling with improved type safety.

Walkthrough

  • New Feature: Added IPv6 support for EC2 instance metadata service endpoints with httpProtocolIpv6 configuration
  • New Feature: Enhanced EFS mount target creation with IPv6 address type support for dual-stack and IPv6-only networking
  • Refactor: Simplified EFS client API with custom types (ElasticFileSystem, MountTargetEFS) replacing direct AWS SDK types
  • Refactor: Updated machine controller manager provider from v0.27.2 to v0.27.3
  • Refactor: Improved CSI EFS driver configuration to dynamically set IMDS endpoint mode based on IP family
  • Chore: Added comprehensive test coverage for new IPv6 instance metadata options functionality

Model: claude-sonnet-4-20250514 | Prompt Tokens: 16050 | Completion Tokens: 247

@federated-github-access federated-github-access Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 13, 2026
AndreasBurger
AndreasBurger reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/approve

Comment thread pkg/aws/client/client.go
fsDescription, err = c.EFS.DescribeFileSystems(ctx, &efs.DescribeFileSystemsInput{
FileSystemId: aws.String(fID),
})
if ignoreNotFound(err) != nil {
Copy link
Copy Markdown
Member

@AndreasBurger AndreasBurger Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should've used IsNotFoundError consitently for this 🫤.

Something to keep in mind for future work on this file.

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2026
@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndreasBurger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Apr 13, 2026

LGTM label has been added.

DetailsGit tree hash: a3dda91d09c523d9408cfe3e3522bf462b856b89

@gardener-prow gardener-prow Bot merged commit 886da6f into gardener:master Apr 13, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees

@kon-angelo kon-angelo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support EFS CSI Driver for IPv6 cluster

4 participants

@hebelsan @gardener-ci-robot @AndreasBurger @kon-angelo