Skip to content

fix cleanup logic when shoot is going to hibernation or waking up#1714

Merged
gardener-prow[bot] merged 1 commit intogardener:masterfrom
DockToFuture:fix/nodeList
Feb 25, 2026
Merged

fix cleanup logic when shoot is going to hibernation or waking up#1714
gardener-prow[bot] merged 1 commit intogardener:masterfrom
DockToFuture:fix/nodeList

Conversation

@DockToFuture
Copy link
Copy Markdown
Member

How to categorize this PR?

/area networking
/kind bug
/platform aws

What this PR does / why we need it:
Fix cleanup logic when shoot is going to hibernation or waking up.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fix cleanup logic when shoot is going to hibernation or waking up.

@DockToFuture DockToFuture requested a review from a team as a code owner February 25, 2026 11:42
@gardener-prow gardener-prow Bot added area/networking Networking related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 25, 2026
@federated-github-access federated-github-access Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
@github-actions github-actions Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 25, 2026
@federated-github-access federated-github-access Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
@github-actions github-actions Bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
wpross
wpross previously approved these changes Feb 25, 2026
Copy link
Copy Markdown
Contributor

@wpross wpross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Feb 25, 2026

LGTM label has been added.

DetailsGit tree hash: 32eb0c3bfd7e67a19dd2b368543f681880ec5e8f

@gardener-prow gardener-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2026
@gardener-prow gardener-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@federated-github-access federated-github-access Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
@github-actions github-actions Bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
@gardener-prow gardener-prow Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This change improves the reliability of Calico network cleanup operations by preventing them from running during cluster hibernation or state transitions. The modification consolidates hibernation state checking logic and removes an unnecessary parameter from the cleanup function.

Walkthrough

  • Bug Fix: Enhanced Calico network cleanup logic to avoid running during cluster hibernation or transition states (hibernating/waking up), preventing potential conflicts and ensuring cleanup only occurs when the cluster is in a stable, active state
  • Refactor: Simplified the cleanup function signature by removing the cluster parameter and moving hibernation checks to the caller, improving code organization and reducing redundant state validation

Model: claude-sonnet-4-20250514 | Prompt Tokens: 643 | Completion Tokens: 138

@federated-github-access federated-github-access Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
Copy link
Copy Markdown
Contributor

@wpross wpross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-actions github-actions Bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 25, 2026
@gardener-prow gardener-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wpross

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented Feb 25, 2026

LGTM label has been added.

DetailsGit tree hash: 922a03f5b1faed3d6bf44c9d2eb489016cb43d0b

@gardener-prow gardener-prow Bot merged commit 3b1610e into gardener:master Feb 25, 2026
48 checks passed
@DockToFuture DockToFuture deleted the fix/nodeList branch February 25, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants