Modernize etcd storageclass to out-of-tree provisioner#1764
Modernize etcd storageclass to out-of-tree provisioner#1764gardener-prow[bot] merged 3 commits intogardener:masterfrom
Conversation
Replace the deprecated in-tree provisioner `kubernetes.io/aws-ebs` with the out-of-tree EBS CSI driver `ebs.csi.aws.com`.
Introduce `config.etcd.storage.parameters` in values.yaml so operators can pass arbitrary CSI driver parameters (e.g. `type`, `kmsKeyId`) without chart changes. The existing `config.etcd.storage.encrypted` boolean is preserved for backwards compatibility: if set, `encrypted: "true"` is still emitted unless the operator has already included `encrypted` in the `parameters` map, avoiding duplicate keys.
|
This update modernizes the AWS EBS storage configuration by transitioning from the legacy Kubernetes EBS provisioner to the AWS EBS CSI driver, while adding flexibility for custom storage parameters in Gardener extension deployments. Walkthrough
Model: claude-sonnet-4-20250514 | Prompt Tokens: 14995 | Completion Tokens: 177 |
|
Especially not sure about the need for backwards compatibility regarding the |
Hm, I’d prefer having the encryption under the parameter field only... |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndreasBurger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: c4685f9b961ed256bb4769014fc9adebf5595fb5 |
|
And it was merged by prow. Splendid. I'll follow up on the latest comment from Alex and do the work |
|
We talked about it, and this is good for now. We'll move towards the new scheme (i.e. using |
How to categorize this PR?
/area storage
/kind enhancement
/platform aws
What this PR does / why we need it:
Modernizes the etcd
StorageClassfor AWS:kubernetes.io/aws-ebswith the EBS CSI driverebs.csi.aws.comtype: gp3disk parameter from theStorageClasstemplate intovalues.yamlunderconfig.etcd.storage.parameters, making it configurable by operators.The existing
config.etcd.storage.encryptedboolean is preserved for backwards compatibility.Which issue(s) this PR fixes:
Fixes #1716
Special notes for your reviewer:
The
StorageClasstemplate now renders arbitrary key/value pairs fromconfig.etcd.storage.parameters, so operators can pass any EBSCSI driver parameter (e.g.
kmsKeyId,throughput) without chart changes.The
encryptedboolean in values is kept for backwards compatibility: if set,encrypted: "true"is still emitted unless the operator has already includedencryptedin theparametersmap, avoiding duplicate keys.Release note: