Conversation
|
This change adds comprehensive monitoring capabilities to the CSI driver controller by exposing metrics on port 3301 and integrating with Prometheus for observability of AWS EBS CSI operations. Walkthrough
Model: claude-sonnet-4-20250514 | Prompt Tokens: 922 | Completion Tokens: 143 |
|
In the issue, you mentioned that we should consider putting this feature behind a flag so it can be enabled on demand, given that it could scale into an unbounded number of metrics. |
I did take a detailed look at the exposed metrics and discussed with @rickardsjp. The following table shows the number of individual metrics that will be generated.
We concluded that the number of additional metrics should not be too much for Prometheus. Worst case the retention time might be reduced. The low risk combined with a need to timely deliver the additional metrics justifies delivering this feature without an additional flag. Footnotes
|
|
LGTM label has been added. DetailsGit tree hash: a71ed1a188338237de34ef4f3397101d7bb8f6e4 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hebelsan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area monitoring
/kind enhancement
/platform aws
What this PR does / why we need it:
This PR enables metrics for the CSI driver and adds a
ServiceMonitorto scrape them.Which issue(s) this PR fixes:
Fixes #1568
Special notes for your reviewer:
Release note: