Feature/cloud profile storage type#1317
Conversation
|
This change enhances the machine class configuration logic to automatically use storage specifications from cloud profiles when not explicitly set in shoot specifications, particularly beneficial for KVM machines requiring premium disk types for boot disks. Walkthrough
The implementation includes proper validation to ensure storage types aren't "default" and handles storage size conversion with appropriate error checking. This enhancement improves the user experience by reducing required configuration while maintaining explicit control when needed. Model: claude-sonnet-4-20250514 | Prompt Tokens: 1630 | Completion Tokens: 181 |
AndreasBurger
left a comment
There was a problem hiding this comment.
since auto-merge is blocked by milestone anyways and this l's gtm I can actually properly approve this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndreasBurger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: ec5f681ff565bdf0c859a84fae48aee288b4f6ac |
How to categorize this PR?
/area quality
/kind enhancement
/platform openstack
What this PR does / why we need it:
This PR adjusts the default values for the machineclass values
rootDiskTypeandrootDiskSize.These will now be derived from the cloudProfile machineType spec which looks the following:
If the storage section of the machineType is not set or the type is set to default the machinclass fields for
rootDiskTypeandrootDiskSizewill be empty so the openstack defaults will be used.It's still possible to overwrite the default disk type and size by setting the shoot fields.
Which issue(s) this PR fixes:
Fixes #1316
Special notes for your reviewer:
Release note: