Simple Backend homework #166
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shara-code
reviewed
Nov 6, 2025
| @@ -1,19 +1,44 @@ | |||
| from fastapi import FastAPI | |||
| from fastapi import FastAPI, HTTPException | |||
| from task_manager import TaskManager | |||
There was a problem hiding this comment.
лучше использовать импорт с точкой from .task_manager import TaskManager
| from pydantic import BaseModel | ||
| from typing import Optional, List | ||
|
|
||
| load_dotenv('passwords.env') |
There was a problem hiding this comment.
хардкод названия файла с секретами это плохо, нужно переделать
| task_data = TaskModel(title=title, description=description, status=status) | ||
| tasks = self._tasks() | ||
| ids = [task['id'] for task in tasks] if tasks else [] | ||
| task_id = max(ids) + 1 if ids else 1 |
There was a problem hiding this comment.
один запрос может переписать другой, нужно подумать как избежать это
| if response.status_code == 200: | ||
| return response.json() | ||
| else: | ||
| raise Exception(f"HTTP Error {response.status_code}: {response.text}") |
| try: | ||
| ai_solution = self.ai.generate_solution(f'{task_data.title}. {task_data.description}') | ||
| except Exception as e: | ||
| ai_solution = f'{e}. Не удалось сгенерировать решение' |
There was a problem hiding this comment.
лучше логировать и возвращать условный null или как-то иначе обрабатывать, чтобы не писать ошибки в базу
| 'X-Master-Key': self.api_key, | ||
| 'Content-Type': 'application/json' | ||
| } | ||
| super().__init__(base_url, headers) |
| task_data = TaskModel(title=title, description=description, status=status) | ||
| tasks = self._tasks() | ||
| ids = [task['id'] for task in tasks] if tasks else [] | ||
| task_id = max(ids) + 1 if ids else 1 |
There was a problem hiding this comment.
не самый эффективный поиск максимального id
|
|
||
| load_dotenv('passwords.env') | ||
|
|
||
| class TaskModel(BaseModel): |
| if task['id'] == task_id: | ||
| for k, v in valid_updates.items(): | ||
| if v is not None: | ||
| task[k] = v |
| timeout=self.timeout, | ||
| **kwargs | ||
| ) | ||
| if response.status_code == 200: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.