-
-
Notifications
You must be signed in to change notification settings - Fork 105
feat: Add restic and OS details to system info #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Broadly looks great, thanks for the interest in contributing the extra details. Left a few nits. Only summary detail I have some reservations about is the storage used mostly from a performance perspective. Overall appreciate the extra details -- agree that this will help users with differentiating installs and keeping track of uptime for noticing crashes (which I think are very rare) is a nice addition. |
Yes, I understand the problem this could pose. |
Hmm, I was thinking on this a bit longer -- we can probably leverage the summary dashboard's refresh logic for a decent solution, see
What if we do the following
In this way, the first request will load fast, the second request follows up with slow to compute data. |
I've removed the space calculation as it can be a performance penalty. |
|
||
if s.orchestrator != nil { | ||
response.ResticPath = s.orchestrator.ResticBinary() | ||
if response.ResticPath != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is quite slow as well-- let's defer it to the future PR as well, with that change I think this LGTM to merge!
When managing multiple systems, it's important to know where I'm connected, the version of backrest, and the OS.
I've included the uptime information because I've occasionally experienced issues with the server rebooting. This way, I know how long backrest has been active.
And it has also happened to me that the DataPath directory grows excessively and fills all the space, so you can control how much it is being used