Skip to content

Added H265#6

Closed
diegonunes4 wants to merge 14 commits into
garethsb:masterfrom
diegonunes4:video-h265
Closed

Added H265#6
diegonunes4 wants to merge 14 commits into
garethsb:masterfrom
diegonunes4:video-h265

Conversation

@diegonunes4

Copy link
Copy Markdown

It's just missing the IS-04 parameters, which ones do you think should be used? @garethsb
Also should I make the PR to the master branch or the video h264?

@garethsb

Copy link
Copy Markdown
Owner

You seem to have merged your H.264 code and my approach to it (nmos/video_h264.{cpp,h}). I don't think we want both. What do you think to the format-specific header/source file approach? Can you also use it for H.265?

@diegonunes4

diegonunes4 commented Jan 31, 2022

Copy link
Copy Markdown
Author

Ok, I will then extract the code and add it to another branch!
I agree with the header/source file, I will use it.

@garethsb

Copy link
Copy Markdown
Owner

which ones do you think should be used?

I previously documented a preliminary look at it here: sony#213 (comment)

Reading the IANA media type registration, linked there, I agree profile-id and level-id may be useful. I think all bit-fields in interop-constraints is covered by existing IS-04 Flow parameters however?

@garethsb

Copy link
Copy Markdown
Owner

I think the best link for the RFC is https://tools.ietf.org/html/rfc7798

@garethsb

garethsb commented Jan 31, 2022

Copy link
Copy Markdown
Owner

This will also make us think about whether we should define common reusable profile_level (or separate profile and level) for the IS-04 Flow, which MPEG 2, AVC, HEVC, VP9, etc. can all use, or whether each format has to have its own similar but different parameters.

@garethsb

garethsb commented Feb 1, 2022

Copy link
Copy Markdown
Owner

Ok, I will then extract the code and add it to another branch!
I agree with the header/source file, I will use it.

Thanks, that'd be great. See if you think the pattern I've used for nmos/video_h264.{h,cpp} can be entirely repeated for H.265 and do it as a separate branch also starting from master.

@garethsb

garethsb commented Feb 1, 2022

Copy link
Copy Markdown
Owner

Closing now we have #7.

@garethsb garethsb closed this Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants