-
Notifications
You must be signed in to change notification settings - Fork 747
Create ieeegray #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create ieeegray #133
Conversation
Matplotlib Style for IEEE Grayscale Plots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you merge all #133 (this PR), #134 and #135 in one pull request? I think one is enough for these changes. I've left some comments here, but I think they are equally applicable on the other PRs.
In general, I'd keep the styles minimal. In my mind, the common use case could be using ["ieee", "ieeegray"]
, instead of just this one. So it would almost be just the figure.dpi
and the properties cyclers.
What are the other style keys for? Are they defined in the IEEE style?
https://electricbookworks.github.io/accellera-style-guide/ieee-sa-standards-style-manual/17.html "Here, there are at least three color options: Black-and-White, Grayscale, and CMYK, along with two different DPI settings (300, 1200). Providing all of these in a single format might be challenging for users. It seems more practical to offer them separately. |
I mean if you can merge the three PRs. I agree on keeping styles in different files, but make everything one PR. |
Matplotlib Style for IEEE Grayscale Plots