fix: require per-project Codex auth approval#2278
Open
time-attack wants to merge 1 commit into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Author
|
@16francej merge pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Gstack now requires each project to approve a specific Codex profile before Codex can run.
How it works
The shared launcher resolves the current project, reads its saved Codex home, validates it, exports it as
CODEX_HOME, and blocks invocation when approval is missing. Skills prompt the user to select a discovered profile or cancel, then disclose the selected path.What was broken
Gstack could silently start Codex using whichever account happened to be authenticated globally, even when that account was inappropriate for the current project.
How it was fixed
I added a hard invocation-layer profile gate, per-project configuration, profile disclosure, and an eval-only bypass. I routed chained review and design calls through the same launcher and removed Codex from autoplan's automatic mechanical decisions.
Verification
The identical production-path probe failed on
origin/mainand passed after the fix in OneManCompany, gbrain, and zotero-arxiv-daily. Explicit bypass controls passed before and after in Plane and Twenty.The focused regression and generated-skill suites passed: 434 tests, 0 failures.
Live evidence gate:
Issue coverage
Closes #965.
Related follow-ups that remain open because this PR does not satisfy their full scope:
CLAUDE_CONFIG_DIRpath supportrefresh_token_reusedrecovery guidance-m gpt-5.2injection #1628 — ChatGPT-account model entitlement selection/autoplanworkflow contract